Chromium Code Reviews
DescriptionFix file chooser on ChromeOS.
A previous CL - https://codereview.chromium.org/2102883002/, introduced
a bug specific to the ChromeOS version of the file chooser. It fixed a
use-after-free bug by monitoring for RenderFrame deletions. However,
on ChromeOS, the file picker is itself a RenderFrame and the code didn't
account for nullifying the cached object only when they match.
This CL fixes the issue by ensuring that the pointer is cleared only
when the object being deleted matches.
BUG=624956
Review-Url: https://codereview.chromium.org/2113353002
Cr-Commit-Position: refs/heads/master@{#403554}
(cherry picked from commit 5e61b75ffa3c2fe805124b5969e8dff578510b99)
Committed: https://chromium.googlesource.com/chromium/src/+/c9bd48036f5e78fdc8aee791d455256532d30c5b
Patch Set 1 #
Messages
Total messages: 4 (2 generated)
|
|||||||||||||||||||