Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2123083002: Delete video-durationchange-on-ended.html test (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
chromium-reviews, blink-reviews, posciak+watch_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete video-durationchange-on-ended.html test The changes which this test was added to verify have been reverted because of issues in MSE playback. So this isn't testing anything and is not useful. So removing this test case. Reverted change: http://crrev.com/1069253004 BUG=588956 Committed: https://crrev.com/048e5019eaf5c88bdb1559c2c41f86777951daa3 Cr-Commit-Position: refs/heads/master@{#403883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
D third_party/WebKit/LayoutTests/media/video-durationchange-on-ended.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-durationchange-on-ended-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-06 05:16:53 UTC) #4
fs
On 2016/07/06 at 05:16:53, srirama.m wrote: > PTAL Could you point to the revert (and ...
4 years, 5 months ago (2016-07-06 08:04:50 UTC) #5
Srirama
On 2016/07/06 08:04:50, fs wrote: > On 2016/07/06 at 05:16:53, srirama.m wrote: > > PTAL ...
4 years, 5 months ago (2016-07-06 08:15:57 UTC) #6
fs
On 2016/07/06 at 08:15:57, srirama.m wrote: > On 2016/07/06 08:04:50, fs wrote: > > On ...
4 years, 5 months ago (2016-07-06 08:32:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123083002/1
4 years, 5 months ago (2016-07-06 08:35:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 11:12:29 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 11:12:31 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 11:14:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/048e5019eaf5c88bdb1559c2c41f86777951daa3
Cr-Commit-Position: refs/heads/master@{#403883}

Powered by Google App Engine
This is Rietveld 408576698