pkg/compiler/lib/src/source_file_provider.dart - Issue 2123073003: remove dependency on compiler from resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/source_file_provider.dart

Issue 2123073003: remove dependency on compiler from resolution (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/source_file_provider.dart

diff --git a/pkg/compiler/lib/src/source_file_provider.dart b/pkg/compiler/lib/src/source_file_provider.dart

index 57bc9d36256f3b03b7cb4f3c0331c6b6192552a1..2e2c7aae999c533160ea9a98d07db7f5dca9a74c 100644

--- a/pkg/compiler/lib/src/source_file_provider.dart

+++ b/pkg/compiler/lib/src/source_file_provider.dart

@@ -168,9 +168,6 @@ class FormattingDiagnosticHandler implements CompilerDiagnostics {

@override

void report(var code, Uri uri, int begin, int end, String message,

api.Diagnostic kind) {

- // TODO(ahe): Remove this when source map is handled differently.

- if (identical(kind.name, 'source map')) return;

if (isAborting) return;

isAborting = (kind == api.Diagnostic.CRASH);