remove dependency on compiler from resolution

remove dependency on compiler from resolution

This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/c5728623b96ee0250b5c08bc23577c878c5b9fec

[Harry Terkelsen, 2016-07-06 22:44:44]

het@google.com changed reviewers:
+ johnniwinther@google.com

[Harry Terkelsen, 2016-07-06 22:44:45]

https://codereview.chromium.org/2123073003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/2123073003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:152: if
(asyncModifier.isAsynchronous) {
this diff looks a lot crazier than it actually is... I am just getting rid of
the check for if we support async/await

[Harry Terkelsen, 2016-07-07 17:13:58]

het@google.com changed reviewers:
+ sra@google.com

[Johnni Winther, 2016-07-08 08:05:39]

lgtm

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/resolution.dart (right):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:15: show AstElement, ClassElement,
ConstructorElement, Element, ExecutableElement, FunctionElement,
FunctionSignature, LibraryElement, MetadataAnnotation, MethodElement,
ResolvedAst, TypedefElement;
Bad dartfmt!

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:282: void
registerCompiletimeError(Element element, DiagnosticMessage message);
Compilertime -> CompileTime?

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (left):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:3580: if
(!compiler.backend.supportsAsyncAwait) {
Dartino still needs this. Move the [supportsAsyncAwait] to [Target] and leave
the check in.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:3721: if
(!compiler.backend.supportsAsyncAwait) {
Ditto.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:4248: if
(!compiler.backend.supportsAsyncAwait) {
Ditto.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/resolution.dart (left):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/resolution.dart:153: if
(!compiler.backend.supportsAsyncAwait) {
Ditto.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/ty...
File pkg/compiler/lib/src/typechecker.dart (left):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/typechecker.dart:1745: if
(compiler.backend.supportsAsyncAwait) {
Ditto.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/typechecker.dart:1872: if
(compiler.backend.supportsAsyncAwait) {
Ditto.

[Harry Terkelsen, 2016-07-18 17:35:59]

Thanks, Johnni!

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/resolution.dart (right):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:15: show AstElement, ClassElement,
ConstructorElement, Element, ExecutableElement, FunctionElement,
FunctionSignature, LibraryElement, MetadataAnnotation, MethodElement,
ResolvedAst, TypedefElement;
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Bad dartfmt!

Done.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:282: void
registerCompiletimeError(Element element, DiagnosticMessage message);
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Compilertime -> CompileTime?

Done.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (left):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:3580: if
(!compiler.backend.supportsAsyncAwait) {
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Dartino still needs this. Move the [supportsAsyncAwait] to [Target] and leave
> the check in.

Done.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:3721: if
(!compiler.backend.supportsAsyncAwait) {
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/resolution.dart (left):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/resolution.dart:153: if
(!compiler.backend.supportsAsyncAwait) {
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/ty...
File pkg/compiler/lib/src/typechecker.dart (left):

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/typechecker.dart:1745: if
(compiler.backend.supportsAsyncAwait) {
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/2123073003/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/typechecker.dart:1872: if
(compiler.backend.supportsAsyncAwait) {
On 2016/07/08 08:05:39, Johnni Winther wrote:
> Ditto.

Done.

[Harry Terkelsen, 2016-07-18 17:40:25]

Description was changed from

==========
remove dependency on compiler from resolution

This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.
==========

to

==========
remove dependency on compiler from resolution

This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5728623b96ee0250b5c08bc23577c878c5b9fec
==========

[Harry Terkelsen, 2016-07-18 17:40:28]

Committed patchset #3 (id:40001) manually as
c5728623b96ee0250b5c08bc23577c878c5b9fec (presubmit successful).