Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/common/crash_keys.cc

Issue 2123073002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update crash keys and add comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/crash_keys.cc
diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc
index 3008497da1744a0fdc83d34aa5d0ef5bc358a2a0..da2cd1495aeddef9b72c0103c4b658a3bb9d75b0 100644
--- a/chrome/common/crash_keys.cc
+++ b/chrome/common/crash_keys.cc
@@ -89,8 +89,10 @@ size_t RegisterChromeCrashKeys() {
// The following keys may be chunked by the underlying crash logging system,
// but ultimately constitute a single key-value pair.
//
- // If you're adding keys here, please also add them to the list in
- // //blimp/engine/app/blimp_engine_crash_keys.cc
+ // If you're adding keys here, please also add them to the following lists:
+ // 1. //blimp/engine/app/blimp_engine_crash_keys.cc and
+ // 2. //chrome/app/chrome_crash_reporter_client_win.cc::
+ // RegisterCrashKeysHelper().
base::debug::CrashKey fixed_keys[] = {
#if defined(OS_MACOSX) || defined(OS_WIN)
{ kMetricsClientId, kSmallSize },

Powered by Google App Engine
This is Rietveld 408576698