chrome/browser/hang_monitor/hang_crash_dump_win.cc - Issue 2123073002: Switch chrome_elf exception handling from breakpad to crashpad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/hang_monitor/hang_crash_dump_win.cc

Issue 2123073002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crash keys and add comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/app/blimp_engine_crash_keys.cc ('K') | « chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/hang_monitor/hang_crash_dump_win.cc

diff --git a/chrome/browser/hang_monitor/hang_crash_dump_win.cc b/chrome/browser/hang_monitor/hang_crash_dump_win.cc

index 456aa389cff48f8e0b0df454eb3cfeefb9338987..64daaf4e3cc41fceadef1d2764d468858d758228 100644

--- a/chrome/browser/hang_monitor/hang_crash_dump_win.cc

+++ b/chrome/browser/hang_monitor/hang_crash_dump_win.cc

@@ -25,7 +25,7 @@ void CrashDumpAndTerminateHungChildProcess(HANDLE hprocess) {

static DumpFunction request_dump = NULL;

if (!request_dump) {

request_dump = reinterpret_cast<DumpFunction>(GetProcAddress(

- GetModuleHandle(chrome::kBrowserProcessExecutableName),

+ GetModuleHandle(chrome::kChromeElfDllName),

"InjectDumpProcessWithoutCrash"));

DCHECK(request_dump) << "Failed loading DumpProcessWithoutCrash: error " <<

GetLastError();

@@ -49,7 +49,7 @@ void CrashDumpForHangDebugging(HANDLE hprocess) {

if (hprocess == GetCurrentProcess()) {

typedef void (__cdecl *DumpFunction)();

DumpFunction request_dump = reinterpret_cast<DumpFunction>(GetProcAddress(

- GetModuleHandle(chrome::kBrowserProcessExecutableName),

+ GetModuleHandle(chrome::kChromeElfDllName),

"DumpProcessWithoutCrash"));

DCHECK(request_dump) << "Failed loading DumpProcessWithoutCrash: error " <<

GetLastError();

@@ -58,7 +58,7 @@ void CrashDumpForHangDebugging(HANDLE hprocess) {

} else {

typedef HANDLE (__cdecl *DumpFunction)(HANDLE);

DumpFunction request_dump = reinterpret_cast<DumpFunction>(GetProcAddress(

- GetModuleHandle(chrome::kBrowserProcessExecutableName),

+ GetModuleHandle(chrome::kChromeElfDllName),

"InjectDumpForHangDebugging"));

DCHECK(request_dump) << "Failed loading InjectDumpForHangDebugging: error "

<< GetLastError();

« blimp/engine/app/blimp_engine_crash_keys.cc ('K') | « chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »