third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp - Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix broken tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

index 1ed8f2c658ca84ec05f2d6f44f53587a6d8587c4..e6f0cf7fcb2188faa319e828414a89a9c6f07f75 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

@@ -88,7 +88,7 @@ FloatPoint ScrollAnimatorBase::currentPosition() const

void ScrollAnimatorBase::notifyPositionChanged()

{

- m_scrollableArea->scrollPositionChanged(m_currentPos, UserScroll);

+ scrollPositionChanged(m_currentPos, UserScroll);

}

DEFINE_TRACE(ScrollAnimatorBase)