third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h - Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix broken tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp ('k') | third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

index 7a8bb6d012a45c8beabec769e63c4ec55db16687..2aa1d6a89fc471574b4b93481eb73bcc7aed0f9e 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

@@ -393,6 +393,7 @@ public:

IntRect resizerCornerRect(const IntRect&, ResizerHitTestType) const;

+ // TODO(ymalik): Remove box() and update callers to use layoutBox() instead.

LayoutBox& box() const;

PaintLayer* layer() const;

@@ -408,6 +409,8 @@ public:

ScrollAnchor& scrollAnchor() { return m_scrollAnchor; }

bool isPaintLayerScrollableArea() const override { return true; }

+ LayoutBox* layoutBox() const override { return &box(); }

bool shouldRebuildHorizontalScrollbarLayer() const { return m_rebuildHorizontalScrollbarLayer; }

bool shouldRebuildVerticalScrollbarLayer() const { return m_rebuildVerticalScrollbarLayer; }

void resetRebuildScrollbarLayerFlags();