Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2123043002: Add a comment why we use HeapVector for a map in EventListenerMap. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment why we use HeapVector for a map in EventListenerMap. See wkrev.com/128002 This CL has no behavior changes. NOTRY=true Committed: https://crrev.com/647600005a2d72d814b036506cf2a80fec72f4ca Cr-Commit-Position: refs/heads/master@{#403839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/events/EventListenerMap.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
kochi@, would you review this please?
4 years, 5 months ago (2016-07-06 00:52:26 UTC) #3
kochi
lgtm
4 years, 5 months ago (2016-07-06 02:20:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123043002/1
4 years, 5 months ago (2016-07-06 02:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 02:24:46 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 02:27:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/647600005a2d72d814b036506cf2a80fec72f4ca
Cr-Commit-Position: refs/heads/master@{#403839}

Powered by Google App Engine
This is Rietveld 408576698