Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: extensions/renderer/resources/guest_view/guest_view_container.js

Issue 2123033002: Remove focus/blur webview handlers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/guest_view_container.js
diff --git a/extensions/renderer/resources/guest_view/guest_view_container.js b/extensions/renderer/resources/guest_view/guest_view_container.js
index acba9fb7b0f0aebc19461937ff220bc8266d4589..8cfc8cb441afa19109e320c0a6405f79e9878a85 100644
--- a/extensions/renderer/resources/guest_view/guest_view_container.js
+++ b/extensions/renderer/resources/guest_view/guest_view_container.js
@@ -101,14 +101,6 @@ GuestViewContainer.prototype.setupFocusPropagation = function() {
// See http://crbug.com/231664.
this.element.setAttribute('tabIndex', -1);
}
- this.element.addEventListener('focus', this.weakWrapper(function(e) {
Fady Samuel 2016/07/06 14:55:06 Not LGTM. This will break focus, although I think
Fady Samuel 2016/07/06 17:31:57 Ah I think I see why/how this is not necessary any
avallee 2016/07/06 17:34:23 I could see how propagating the event might make s
- // Focus the BrowserPlugin when the GuestViewContainer takes focus.
- privates(this).internalElement.focus();
- }));
- this.element.addEventListener('blur', this.weakWrapper(function(e) {
- // Blur the BrowserPlugin when the GuestViewContainer loses focus.
- privates(this).internalElement.blur();
- }));
};
GuestViewContainer.prototype.focus = function() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698