Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212303005: Revert of Remove prefixed Shadow DOM APIs in Element. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
esprehn, hayato, dglazkov
CC:
blink-reviews, caseq+blink_chromium.org, sof, loislo+blink_chromium.org, eustas+blink_chromium.org, rwlbuis, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert of Remove prefixed Shadow DOM APIs in Element. (https://codereview.chromium.org/208503004/) Reason for revert: Breaks many browser tests: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35489 Original issue's description: > Remove prefixed Shadow DOM APIs in Element. > > It's time to remove. We've shipped unprefixed APIs for these APIs. > > BUG=336121 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170008 TBR=dglazkov@chromium.org,esprehn@chromium.org,hayato@chromium.org NOTREECHECKS=true NOTRY=true BUG=336121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-distributed-child-is-not-inert.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/gc-treescope.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reattach-content-ancestor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reinsert-insertion-point.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-spellcheck.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/stale-distribution-after-shadow-removal.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-protocol/shadow-dom-rules-in-styleSheetAddedEvent.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/breadcrumb-shadow-roots.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/shadow-dom-rules.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Events/EventsDispatchingInDeeplyNestedShadowTrees.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Events/EventsDispatchingInShadowTrees.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ChangingClassNameShadowDOM.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ChangingSelect.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ContentReprojection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M PerformanceTests/ShadowDOM/DistributionWithMultipleShadowRoots.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/LargeDistributionWithoutLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/MultipleInsertionPoints.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ShadowReprojection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M PerformanceTests/ShadowDOM/SmallDistributionWithLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of Remove prefixed Shadow DOM APIs in Element.
6 years, 9 months ago (2014-03-26 09:23:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212303005/1
6 years, 9 months ago (2014-03-26 09:23:36 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 09:24:13 UTC) #3
Message was sent while issue was closed. 
Change committed as 170036

Powered by Google App Engine
This is Rietveld 408576698