Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2123003003: Convert text-track-selection* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert text-track-selection* tests to testharness.js Cleaning up text-track-selection* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/379738c07c9a610d83b83743d0ca934decc42232 Cr-Commit-Position: refs/heads/master@{#403932}

Patch Set 1 #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-06 16:04:11 UTC) #4
fs
lgtm
4 years, 5 months ago (2016-07-06 16:10:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123003003/1
4 years, 5 months ago (2016-07-06 16:52:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 18:06:21 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 18:06:40 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:08:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/379738c07c9a610d83b83743d0ca934decc42232
Cr-Commit-Position: refs/heads/master@{#403932}

Powered by Google App Engine
This is Rietveld 408576698