Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2122983002: [SPv2] Add unit test for foreign layers in layer list path. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
pdr., trchen
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Add unit test for foreign layers in layer list path. This already works, but this CL adds unit test coverage for it by cloning the unit test for the non-layer-list path. BUG=563667 Committed: https://crrev.com/63ebd0b8a5853691eb0babbc7fb3f198ba6e1f64 Cr-Commit-Position: refs/heads/master@{#404055}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 chunk +14 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
jbroman
4 years, 5 months ago (2016-07-05 17:59:52 UTC) #2
pdr.
https://codereview.chromium.org/2122983002/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp (right): https://codereview.chromium.org/2122983002/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp#newcode521 third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:521: TEST_F(PaintArtifactCompositorTestWithPropertyTrees, ForeignLayerPassesThrough) WDYT about extracting this out so PaintArtifactCompositorTestWithPropertyTrees ...
4 years, 5 months ago (2016-07-06 23:23:23 UTC) #3
jbroman
https://codereview.chromium.org/2122983002/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp (right): https://codereview.chromium.org/2122983002/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp#newcode521 third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:521: TEST_F(PaintArtifactCompositorTestWithPropertyTrees, ForeignLayerPassesThrough) On 2016/07/06 at 23:23:23, pdr. wrote: > ...
4 years, 5 months ago (2016-07-07 00:18:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122983002/1
4 years, 5 months ago (2016-07-07 00:19:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 03:05:22 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 03:05:24 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 03:06:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63ebd0b8a5853691eb0babbc7fb3f198ba6e1f64
Cr-Commit-Position: refs/heads/master@{#404055}

Powered by Google App Engine
This is Rietveld 408576698