Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: src/heap/remembered-set.cc

Issue 2122963002: [heap] Clear slots for map space when writing zap values (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/remembered-set.cc
diff --git a/src/heap/remembered-set.cc b/src/heap/remembered-set.cc
index 6e27c288cf69cafae6fb7a0a06f5b23ee2ecad1e..e6a4a5f983bcc3590fe4da0da76fe95fc1adcfe3 100644
--- a/src/heap/remembered-set.cc
+++ b/src/heap/remembered-set.cc
@@ -39,6 +39,19 @@ void RememberedSet<direction>::ClearInvalidSlots(Heap* heap) {
});
}
}
+ if (Heap::ShouldZapGarbage()) {
+ // Need to filter invalid slots as we overwrite them with zap values in
+ // during sweeping which runs concurrently with pointer updating.
+ for (MemoryChunk* chunk : *heap->map_space()) {
+ SlotSet* slots = GetSlotSet(chunk);
+ if (slots != nullptr) {
+ slots->Iterate([heap, chunk](Address addr) {
+ Object** slot = reinterpret_cast<Object**>(addr);
+ return IsValidSlot(heap, chunk, slot) ? KEEP_SLOT : REMOVE_SLOT;
+ });
+ }
+ }
+ }
}
template <PointerDirection direction>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698