Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2122963002: [heap] Clear slots for map space when writing zap values (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Clear slots for map space when writing zap values Pointer updating requires the all slots to be valid. If we write zap values in the sweeper we need to filter out invalid slots before. BUG=chromium:625748 LOG=N R=ulan@chromium.org Committed: https://crrev.com/9a4132aad254894df4e8e7f41bb8ceefd266d721 Cr-Commit-Position: refs/heads/master@{#37538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/heap/remembered-set.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
4 years, 5 months ago (2016-07-05 16:34:28 UTC) #1
ulan
lgtm
4 years, 5 months ago (2016-07-05 16:35:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122963002/1
4 years, 5 months ago (2016-07-05 16:35:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 16:58:38 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 17:00:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a4132aad254894df4e8e7f41bb8ceefd266d721
Cr-Commit-Position: refs/heads/master@{#37538}

Powered by Google App Engine
This is Rietveld 408576698