Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 2122953002: [crankshaft] do not restore rsi in stub for deferred number conversions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixing wrong registers Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 4177 matching lines...) Expand 10 before | Expand all | Expand 10 after
4188 4188
4189 4189
4190 void LCodeGen::DoDeferredNumberTagD(LNumberTagD* instr) { 4190 void LCodeGen::DoDeferredNumberTagD(LNumberTagD* instr) {
4191 // TODO(3095996): Get rid of this. For now, we need to make the 4191 // TODO(3095996): Get rid of this. For now, we need to make the
4192 // result register contain a valid pointer because it is already 4192 // result register contain a valid pointer because it is already
4193 // contained in the register pointer map. 4193 // contained in the register pointer map.
4194 Register result = ToRegister(instr->result()); 4194 Register result = ToRegister(instr->result());
4195 __ Mov(result, 0); 4195 __ Mov(result, 0);
4196 4196
4197 PushSafepointRegistersScope scope(this); 4197 PushSafepointRegistersScope scope(this);
4198 // NumberTagU and NumberTagD use the context from the frame, rather than 4198 // Reset the context register.
4199 // the environment's HContext or HInlinedContext value. 4199 if (!result.is(cp)) {
4200 // They only call Runtime::kAllocateHeapNumber. 4200 __ Mov(cp, 0);
4201 // The corresponding HChange instructions are added in a phase that does 4201 }
4202 // not have easy access to the local context.
4203 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
4204 __ CallRuntimeSaveDoubles(Runtime::kAllocateHeapNumber); 4202 __ CallRuntimeSaveDoubles(Runtime::kAllocateHeapNumber);
4205 RecordSafepointWithRegisters( 4203 RecordSafepointWithRegisters(
4206 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt); 4204 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);
4207 __ StoreToSafepointRegisterSlot(x0, result); 4205 __ StoreToSafepointRegisterSlot(x0, result);
4208 } 4206 }
4209 4207
4210 4208
4211 void LCodeGen::DoNumberTagD(LNumberTagD* instr) { 4209 void LCodeGen::DoNumberTagD(LNumberTagD* instr) {
4212 class DeferredNumberTagD: public LDeferredCode { 4210 class DeferredNumberTagD: public LDeferredCode {
4213 public: 4211 public:
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
4253 4251
4254 // Slow case: call the runtime system to do the number allocation. 4252 // Slow case: call the runtime system to do the number allocation.
4255 __ Bind(&slow); 4253 __ Bind(&slow);
4256 // TODO(3095996): Put a valid pointer value in the stack slot where the result 4254 // TODO(3095996): Put a valid pointer value in the stack slot where the result
4257 // register is stored, as this register is in the pointer map, but contains an 4255 // register is stored, as this register is in the pointer map, but contains an
4258 // integer value. 4256 // integer value.
4259 __ Mov(dst, 0); 4257 __ Mov(dst, 0);
4260 { 4258 {
4261 // Preserve the value of all registers. 4259 // Preserve the value of all registers.
4262 PushSafepointRegistersScope scope(this); 4260 PushSafepointRegistersScope scope(this);
4263 4261 // Reset the context register.
4264 // NumberTagU and NumberTagD use the context from the frame, rather than 4262 if (!dst.is(cp)) {
4265 // the environment's HContext or HInlinedContext value. 4263 __ Mov(cp, 0);
4266 // They only call Runtime::kAllocateHeapNumber. 4264 }
4267 // The corresponding HChange instructions are added in a phase that does
4268 // not have easy access to the local context.
4269 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
4270 __ CallRuntimeSaveDoubles(Runtime::kAllocateHeapNumber); 4265 __ CallRuntimeSaveDoubles(Runtime::kAllocateHeapNumber);
4271 RecordSafepointWithRegisters( 4266 RecordSafepointWithRegisters(
4272 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt); 4267 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);
4273 __ StoreToSafepointRegisterSlot(x0, dst); 4268 __ StoreToSafepointRegisterSlot(x0, dst);
4274 } 4269 }
4275 4270
4276 // Convert number to floating point and store in the newly allocated heap 4271 // Convert number to floating point and store in the newly allocated heap
4277 // number. 4272 // number.
4278 __ Bind(&convert_and_store); 4273 __ Bind(&convert_and_store);
4279 DoubleRegister dbl_scratch = double_scratch(); 4274 DoubleRegister dbl_scratch = double_scratch();
(...skipping 1437 matching lines...) Expand 10 before | Expand all | Expand 10 after
5717 // Index is equal to negated out of object property index plus 1. 5712 // Index is equal to negated out of object property index plus 1.
5718 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5713 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5719 __ Ldr(result, FieldMemOperand(result, 5714 __ Ldr(result, FieldMemOperand(result,
5720 FixedArray::kHeaderSize - kPointerSize)); 5715 FixedArray::kHeaderSize - kPointerSize));
5721 __ Bind(deferred->exit()); 5716 __ Bind(deferred->exit());
5722 __ Bind(&done); 5717 __ Bind(&done);
5723 } 5718 }
5724 5719
5725 } // namespace internal 5720 } // namespace internal
5726 } // namespace v8 5721 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698