Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: gni/v8.gni

Issue 2122933002: [gn] Switch more linux32 bots to gn (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Set default for external startup data Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index fb36239300f41b5b03e04358cb985032bd790365..93b766920a7c71bfc7e10d1b36fea5902390a8f5 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -22,7 +22,13 @@ declare_args() {
# Use external files for startup data blobs:
# the JS builtins sources and the start snapshot.
- v8_use_external_startup_data = !is_ios
+ v8_use_external_startup_data = ""
+}
+
+if (v8_use_external_startup_data == "") {
+ # If not specified as a gn arg, use external startup data by default if
+ # a snapshot is used and if we're not on ios.
+ v8_use_external_startup_data = v8_use_snapshot && !is_ios
}
###############################################################################
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698