[gn] Switch more linux32 bots to gn

[gn] Switch more linux32 bots to gn

This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a
Cr-Commit-Position: refs/heads/master@{#37546}

[Michael Achenbach, 2016-07-05 15:16:40]

Description was changed from

==========
[gn] Switch more linux32 bots to gn

BUG=
==========

to

==========
[gn] Switch more linux32 bots to gn

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-07-05 15:16:40]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-07-06 08:43:31]

Description was changed from

==========
[gn] Switch more linux32 bots to gn

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Switch more linux32 bots to gn

This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-07-06 08:50:00]

PTAL.

Links:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build...

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20bui...

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20deb...

I decided to explicitly switch off external startup data in nosnap mode, as
otherwise a bunch of preprocessor defines are creeping around.

A small irregularity is that we're setting USING_V8_SHARED in a few v8 source
files. E.g. we set it for v8dll-main.cc because the external_config from
https://cs.chromium.org/chromium/src/v8/BUILD.gn?l=2153 is not only applied
upwards in the dependency tree, but also on the component itself. But since also
https://cs.chromium.org/chromium/src/v8/src/v8dll-main.cc?q=USING_V8_SHARED+f...
unsets it, I guess it doesn't matter.

Also the cctests and unittests set USING_V8_SHARED. It's not used anywhere in
those files and it's guarded here
https://cs.chromium.org/chromium/src/v8/include/v8.h?q=USING_V8_SHARED+file:%...
- I assume that if we don't run into the guard, everything is fine.

[vogelheim, 2016-07-06 09:49:37]

On 2016/07/06 08:50:00, Michael Achenbach wrote:
> A small irregularity is that we're setting USING_V8_SHARED in a few v8 source
> files. E.g. we set it for v8dll-main.cc because the external_config from
> https://cs.chromium.org/chromium/src/v8/BUILD.gn?l=2153 is not only applied
> upwards in the dependency tree, but also on the component itself. But since
also
>
https://cs.chromium.org/chromium/src/v8/src/v8dll-main.cc?q=USING_V8_SHARED+f...
> unsets it, I guess it doesn't matter.
> 
> Also the cctests and unittests set USING_V8_SHARED. It's not used anywhere in
> those files and it's guarded here
>
https://cs.chromium.org/chromium/src/v8/include/v8.h?q=USING_V8_SHARED+file:%...
> - I assume that if we don't run into the guard, everything is fine.

I'd agree, but I don't really understand the .dll mechanism. I hope Jochen can
comment.

[vogelheim, 2016-07-06 09:49:46]

lgtm

[Michael Achenbach, 2016-07-06 09:53:03]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-06 09:53:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 09:55:10]

Description was changed from

==========
[gn] Switch more linux32 bots to gn

This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Switch more linux32 bots to gn

This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true
==========

[commit-bot: I haz the power, 2016-07-06 09:55:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 09:57:29]

Description was changed from

==========
[gn] Switch more linux32 bots to gn

This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Switch more linux32 bots to gn

This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a
Cr-Commit-Position: refs/heads/master@{#37546}
==========

[commit-bot: I haz the power, 2016-07-06 09:57:30]

Patchset 3 (id:??) landed as
https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a
Cr-Commit-Position: refs/heads/master@{#37546}

[Michael Achenbach, 2016-07-06 10:13:17]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2128493002/ by machenbach@chromium.org.

The reason for reverting is: Breaks test isolation on shared library bot..