Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2122903002: Move search-related files from chrome/common to chrome/common/search (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move search-related files from chrome/common to chrome/common/search This allows us to have a more specific OWNERS file than the one in chrome/ or chrome/common/ Committed: https://crrev.com/4dff7cfe023ae5086c4c2feca75d5738617b6493 Cr-Commit-Position: refs/heads/master@{#403869}

Patch Set 1 #

Patch Set 2 : move search-related files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -702 lines) Patch
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_model.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_model_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/metrics_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/OWNERS View 1 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/common/instant_types.h View 1 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/common/instant_types.cc View 1 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/common/instant_types_unittest.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/common/ntp_logging_events.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/common/render_messages.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/search/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/search/instant_types.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/search/instant_types.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/search/instant_types_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/search/ntp_logging_events.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/search/search_types.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/search/search_urls.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/search/search_urls.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/search/search_urls_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/search_types.h View 1 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/common/search_urls.h View 1 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/common/search_urls.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/search_urls_unittest.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/renderer/instant_restricted_id_cache.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/search_bouncer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
Marc Treib
4 years, 5 months ago (2016-07-05 13:42:35 UTC) #3
jochen (gone - plz use gerrit)
what about moving all that stuff to a sub directory?
4 years, 5 months ago (2016-07-05 13:44:20 UTC) #4
Marc Treib
On 2016/07/05 13:44:20, jochen wrote: > what about moving all that stuff to a sub ...
4 years, 5 months ago (2016-07-05 13:51:34 UTC) #5
jochen (gone - plz use gerrit)
On 2016/07/05 at 13:51:34, treib wrote: > On 2016/07/05 13:44:20, jochen wrote: > > what ...
4 years, 5 months ago (2016-07-05 14:05:10 UTC) #6
Marc Treib
On 2016/07/05 14:05:10, jochen wrote: > On 2016/07/05 at 13:51:34, treib wrote: > > On ...
4 years, 5 months ago (2016-07-05 15:54:03 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-05 15:56:57 UTC) #9
Marc Treib
+dcheng - can I get a rubber-stamp for the include changes in render_messages.h please? Thanks!
4 years, 5 months ago (2016-07-05 16:01:24 UTC) #11
dcheng
rs lgtm for updating include paths in render_messages.h
4 years, 5 months ago (2016-07-06 01:57:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122903002/20001
4 years, 5 months ago (2016-07-06 08:03:45 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 08:53:46 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 08:53:51 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 08:55:27 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4dff7cfe023ae5086c4c2feca75d5738617b6493
Cr-Commit-Position: refs/heads/master@{#403869}

Powered by Google App Engine
This is Rietveld 408576698