Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 2122873002: Add virtualKeyboardPrivate.onKeyboardClosed API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_controller.cc
diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc
index 71b55b02c233ceadb1d8a5979418674efbf0e06b..ff71e8145ccc3ea5d07e93b1d40bb1c1c3c88d10 100644
--- a/ui/keyboard/keyboard_controller.cc
+++ b/ui/keyboard/keyboard_controller.cc
@@ -185,6 +185,8 @@ KeyboardController::~KeyboardController() {
if (container_->GetRootWindow())
container_->GetRootWindow()->RemoveObserver(this);
container_->RemoveObserver(this);
+ FOR_EACH_OBSERVER(KeyboardControllerObserver, observer_list_,
sky 2016/07/06 16:03:00 How come you're only calling OnKeyboardDestroyed()
Azure Wei 2016/07/08 06:35:24 Want to make sure the container_ has been created
+ OnKeyboardDestroyed());
}
if (input_method_)
input_method_->RemoveObserver(this);

Powered by Google App Engine
This is Rietveld 408576698