Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 2122853002: Implement UnaligedLoad and UnaligedStore turbofan operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Nits. Fixes some errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | src/machine-type.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 AddressingMode addressing_mode = 297 AddressingMode addressing_mode =
298 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count); 298 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count);
299 InstructionCode code = 299 InstructionCode code =
300 opcode | AddressingModeField::encode(addressing_mode); 300 opcode | AddressingModeField::encode(addressing_mode);
301 inputs[input_count++] = val; 301 inputs[input_count++] = val;
302 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count, 302 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count,
303 inputs); 303 inputs);
304 } 304 }
305 } 305 }
306 306
307 // Architecture supports unaligned access, therefore VisitLoad is used instead
308 void InstructionSelector::VisitUnalignedLoad(Node* node) { UNREACHABLE(); }
309
310 // Architecture supports unaligned access, therefore VisitStore is used instead
311 void InstructionSelector::VisitUnalignedStore(Node* node) { UNREACHABLE(); }
307 312
308 void InstructionSelector::VisitCheckedLoad(Node* node) { 313 void InstructionSelector::VisitCheckedLoad(Node* node) {
309 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op()); 314 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op());
310 X87OperandGenerator g(this); 315 X87OperandGenerator g(this);
311 Node* const buffer = node->InputAt(0); 316 Node* const buffer = node->InputAt(0);
312 Node* const offset = node->InputAt(1); 317 Node* const offset = node->InputAt(1);
313 Node* const length = node->InputAt(2); 318 Node* const length = node->InputAt(2);
314 ArchOpcode opcode = kArchNop; 319 ArchOpcode opcode = kArchNop;
315 switch (load_rep.representation()) { 320 switch (load_rep.representation()) {
316 case MachineRepresentation::kWord8: 321 case MachineRepresentation::kWord8:
(...skipping 1411 matching lines...) Expand 10 before | Expand all | Expand 10 after
1728 // static 1733 // static
1729 MachineOperatorBuilder::AlignmentRequirements 1734 MachineOperatorBuilder::AlignmentRequirements
1730 InstructionSelector::AlignmentRequirements() { 1735 InstructionSelector::AlignmentRequirements() {
1731 return MachineOperatorBuilder::AlignmentRequirements:: 1736 return MachineOperatorBuilder::AlignmentRequirements::
1732 FullUnalignedAccessSupport(); 1737 FullUnalignedAccessSupport();
1733 } 1738 }
1734 1739
1735 } // namespace compiler 1740 } // namespace compiler
1736 } // namespace internal 1741 } // namespace internal
1737 } // namespace v8 1742 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | src/machine-type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698