Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 2122853002: Implement UnaligedLoad and UnaligedStore turbofan operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Nits. Fixes some errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/compiler/x87/instruction-selector-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 6
7 #include "src/base/adapters.h" 7 #include "src/base/adapters.h"
8 #include "src/compiler/instruction-selector-impl.h" 8 #include "src/compiler/instruction-selector-impl.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/node-properties.h" 10 #include "src/compiler/node-properties.h"
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 InstructionCode code = 270 InstructionCode code =
271 opcode | AddressingModeField::encode(addressing_mode); 271 opcode | AddressingModeField::encode(addressing_mode);
272 InstructionOperand value_operand = 272 InstructionOperand value_operand =
273 g.CanBeImmediate(value) ? g.UseImmediate(value) : g.UseRegister(value); 273 g.CanBeImmediate(value) ? g.UseImmediate(value) : g.UseRegister(value);
274 inputs[input_count++] = value_operand; 274 inputs[input_count++] = value_operand;
275 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count, 275 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count,
276 inputs); 276 inputs);
277 } 277 }
278 } 278 }
279 279
280 // Architecture supports unaligned access, therefore VisitLoad is used instead
281 void InstructionSelector::VisitUnalignedLoad(Node* node) { UNREACHABLE(); }
282
283 // Architecture supports unaligned access, therefore VisitStore is used instead
284 void InstructionSelector::VisitUnalignedStore(Node* node) { UNREACHABLE(); }
280 285
281 void InstructionSelector::VisitCheckedLoad(Node* node) { 286 void InstructionSelector::VisitCheckedLoad(Node* node) {
282 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op()); 287 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op());
283 X64OperandGenerator g(this); 288 X64OperandGenerator g(this);
284 Node* const buffer = node->InputAt(0); 289 Node* const buffer = node->InputAt(0);
285 Node* const offset = node->InputAt(1); 290 Node* const offset = node->InputAt(1);
286 Node* const length = node->InputAt(2); 291 Node* const length = node->InputAt(2);
287 ArchOpcode opcode = kArchNop; 292 ArchOpcode opcode = kArchNop;
288 switch (load_rep.representation()) { 293 switch (load_rep.representation()) {
289 case MachineRepresentation::kWord8: 294 case MachineRepresentation::kWord8:
(...skipping 1858 matching lines...) Expand 10 before | Expand all | Expand 10 after
2148 // static 2153 // static
2149 MachineOperatorBuilder::AlignmentRequirements 2154 MachineOperatorBuilder::AlignmentRequirements
2150 InstructionSelector::AlignmentRequirements() { 2155 InstructionSelector::AlignmentRequirements() {
2151 return MachineOperatorBuilder::AlignmentRequirements:: 2156 return MachineOperatorBuilder::AlignmentRequirements::
2152 FullUnalignedAccessSupport(); 2157 FullUnalignedAccessSupport();
2153 } 2158 }
2154 2159
2155 } // namespace compiler 2160 } // namespace compiler
2156 } // namespace internal 2161 } // namespace internal
2157 } // namespace v8 2162 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/compiler/x87/instruction-selector-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698