Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 2122853002: Implement UnaligedLoad and UnaligedStore turbofan operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Nits. Fixes some errors Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 AddressingMode addressing_mode = 336 AddressingMode addressing_mode =
337 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count); 337 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count);
338 InstructionCode code = 338 InstructionCode code =
339 opcode | AddressingModeField::encode(addressing_mode); 339 opcode | AddressingModeField::encode(addressing_mode);
340 inputs[input_count++] = val; 340 inputs[input_count++] = val;
341 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count, 341 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count,
342 inputs); 342 inputs);
343 } 343 }
344 } 344 }
345 345
346 // Architecture supports unaligned access, therefore VisitLoad is used instead
347 void InstructionSelector::VisitUnalignedLoad(Node* node) { UNREACHABLE(); }
348
349 // Architecture supports unaligned access, therefore VisitStore is used instead
350 void InstructionSelector::VisitUnalignedStore(Node* node) { UNREACHABLE(); }
346 351
347 void InstructionSelector::VisitCheckedLoad(Node* node) { 352 void InstructionSelector::VisitCheckedLoad(Node* node) {
348 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op()); 353 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op());
349 IA32OperandGenerator g(this); 354 IA32OperandGenerator g(this);
350 Node* const buffer = node->InputAt(0); 355 Node* const buffer = node->InputAt(0);
351 Node* const offset = node->InputAt(1); 356 Node* const offset = node->InputAt(1);
352 Node* const length = node->InputAt(2); 357 Node* const length = node->InputAt(2);
353 ArchOpcode opcode = kArchNop; 358 ArchOpcode opcode = kArchNop;
354 switch (load_rep.representation()) { 359 switch (load_rep.representation()) {
355 case MachineRepresentation::kWord8: 360 case MachineRepresentation::kWord8:
(...skipping 1339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1695 // static 1700 // static
1696 MachineOperatorBuilder::AlignmentRequirements 1701 MachineOperatorBuilder::AlignmentRequirements
1697 InstructionSelector::AlignmentRequirements() { 1702 InstructionSelector::AlignmentRequirements() {
1698 return MachineOperatorBuilder::AlignmentRequirements:: 1703 return MachineOperatorBuilder::AlignmentRequirements::
1699 FullUnalignedAccessSupport(); 1704 FullUnalignedAccessSupport();
1700 } 1705 }
1701 1706
1702 } // namespace compiler 1707 } // namespace compiler
1703 } // namespace internal 1708 } // namespace internal
1704 } // namespace v8 1709 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698