Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2122843002: Add test case to test that empty supported payment method identifiers throw TypeError. (Closed)

Created:
4 years, 5 months ago by pals
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test case to test that empty supported payment method identifiers throw TypeError. BUG=587995 Committed: https://crrev.com/c42ffcad7cfef3c3737fed642cdb24f44341ddda Cr-Commit-Position: refs/heads/master@{#403854}

Patch Set 1 #

Patch Set 2 : buildDetails #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pals
I am going through the spec. Looks like the above test case is missing. PTAL.
4 years, 5 months ago (2016-07-05 08:53:18 UTC) #3
please use gerrit instead
lgtm
4 years, 5 months ago (2016-07-05 10:05:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122843002/20001
4 years, 5 months ago (2016-07-05 10:25:31 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/257246)
4 years, 5 months ago (2016-07-05 13:08:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122843002/20001
4 years, 5 months ago (2016-07-06 02:43:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 05:27:11 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 05:27:14 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 05:29:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c42ffcad7cfef3c3737fed642cdb24f44341ddda
Cr-Commit-Position: refs/heads/master@{#403854}

Powered by Google App Engine
This is Rietveld 408576698