Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2122833002: Remove SHARED_BUFFER_STATS (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 5 months ago
Reviewers:
jbroman
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SHARED_BUFFER_STATS SHARED_BUFFER_STATS is not defined by default and fails to compile even if it's enabled. Apparently, it's not used anymore. Committed: https://crrev.com/e76fbccaf5ab07463a6d2afa629f324a1c785242 Cr-Commit-Position: refs/heads/master@{#403777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -109 lines) Patch
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 6 chunks +0 lines, -109 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tzik
PTAL
4 years, 5 months ago (2016-07-05 06:54:24 UTC) #3
jbroman
lgtm
4 years, 5 months ago (2016-07-05 14:00:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122833002/1
4 years, 5 months ago (2016-07-05 14:00:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 14:04:49 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 14:04:53 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 14:06:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e76fbccaf5ab07463a6d2afa629f324a1c785242
Cr-Commit-Position: refs/heads/master@{#403777}

Powered by Google App Engine
This is Rietveld 408576698