tools/metrics/histograms/histograms.xml - Issue 2122783002: Add metrics for app banner preventDefault() and prompt().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2122783002: Add metrics for app banner preventDefault() and prompt(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 30fcf9c3355df698399f4dc66947f4cd661ced55..3206bf0b2a2d0cbd895ac853839315a625d0a514 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -65508,6 +65508,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

benwells 2016/07/05 02:56:20 What does this mean? I find the labels for this me

dominickn 2016/07/05 03:15:33 The "requested" state occurs after the manifest wa

+ <int value="13" label="Banner prevented by the page before it was shown"/>

+ <int value="14" label="Banner prompted by the page after it was prevented"/>

</enum>

« chrome/browser/banners/app_banner_data_fetcher.cc ('K') | « chrome/browser/banners/app_banner_metrics.h ('k') | no next file » | no next file with comments »