Chromium Code Reviews Chromium Code Reviews
Issue 2122783002:
Add metrics for app banner preventDefault() and prompt(). (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_METRICS_H_ | 5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_METRICS_H_ |
| 6 #define CHROME_BROWSER_BANNERS_APP_BANNER_METRICS_H_ | 6 #define CHROME_BROWSER_BANNERS_APP_BANNER_METRICS_H_ |
| 7 | 7 |
| 8 namespace banners { | 8 namespace banners { |
| 9 | 9 |
| 10 // Keep in sync with the values defined in histograms.xml. | 10 // Keep in sync with the values defined in histograms.xml. |
| (...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 50 USER_RESPONSE_MIN = 0, | 50 USER_RESPONSE_MIN = 0, |
| 51 USER_RESPONSE_NATIVE_APP_ACCEPTED = 1, | 51 USER_RESPONSE_NATIVE_APP_ACCEPTED = 1, |
| 52 USER_RESPONSE_WEB_APP_ACCEPTED = 2, | 52 USER_RESPONSE_WEB_APP_ACCEPTED = 2, |
| 53 USER_RESPONSE_NATIVE_APP_DISMISSED = 3, | 53 USER_RESPONSE_NATIVE_APP_DISMISSED = 3, |
| 54 USER_RESPONSE_WEB_APP_DISMISSED = 4, | 54 USER_RESPONSE_WEB_APP_DISMISSED = 4, |
| 55 USER_RESPONSE_NATIVE_APP_IGNORED = 5, | 55 USER_RESPONSE_NATIVE_APP_IGNORED = 5, |
| 56 USER_RESPONSE_WEB_APP_IGNORED = 6, | 56 USER_RESPONSE_WEB_APP_IGNORED = 6, |
| 57 USER_RESPONSE_MAX = 7, | 57 USER_RESPONSE_MAX = 7, |
| 58 }; | 58 }; |
| 59 | 59 |
| 60 enum BeforeInstallEvent { | |
|
Ilya Sherman
2016/07/06 23:15:53
nit: Please document that this enum is used to bac
dominickn
2016/07/07 00:16:02
Done.
| |
| 61 BEFORE_INSTALL_EVENT_MIN = 0, | |
|
Ilya Sherman
2016/07/06 23:15:53
Hmm, why are you reserving this bucket? It doesn'
dominickn
2016/07/07 00:16:02
It's mainly for consistency with the remainder of
| |
| 62 BEFORE_INSTALL_EVENT_CREATED = 1, | |
| 63 BEFORE_INSTALL_EVENT_COMPLETE = 2, | |
| 64 BEFORE_INSTALL_EVENT_NO_ACTION = 3, | |
| 65 BEFORE_INSTALL_EVENT_PREVENT_DEFAULT_CALLED = 4, | |
| 66 BEFORE_INSTALL_EVENT_PROMPT_CALLED_AFTER_PREVENT_DEFAULT = 5, | |
| 67 BEFORE_INSTALL_EVENT_PROMPT_NOT_CALLED_AFTER_PREVENT_DEFAULT = 6, | |
| 68 BEFORE_INSTALL_EVENT_MAX = 7, | |
| 69 }; | |
| 70 | |
| 60 extern const char kDismissEventHistogram[]; | 71 extern const char kDismissEventHistogram[]; |
| 61 extern const char kDisplayEventHistogram[]; | 72 extern const char kDisplayEventHistogram[]; |
| 62 extern const char kInstallEventHistogram[]; | 73 extern const char kInstallEventHistogram[]; |
| 63 extern const char kMinutesHistogram[]; | 74 extern const char kMinutesHistogram[]; |
| 64 extern const char kUserResponseHistogram[]; | 75 extern const char kUserResponseHistogram[]; |
| 76 extern const char kBeforeInstallEventHistogram[]; | |
| 65 | 77 |
| 66 void TrackDismissEvent(int event); | 78 void TrackDismissEvent(int event); |
| 67 void TrackDisplayEvent(int event); | 79 void TrackDisplayEvent(int event); |
| 68 void TrackInstallEvent(int event); | 80 void TrackInstallEvent(int event); |
| 69 void TrackMinutesFromFirstVisitToBannerShown(int minutes); | 81 void TrackMinutesFromFirstVisitToBannerShown(int minutes); |
| 70 void TrackUserResponse(int event); | 82 void TrackUserResponse(int event); |
| 83 void TrackBeforeInstallEvent(int event); | |
| 71 | 84 |
| 72 }; // namespace banners | 85 }; // namespace banners |
| 73 | 86 |
| 74 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_METRICS_H_ | 87 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_METRICS_H_ |
| OLD | NEW |
