Add metrics for app banner preventDefault() and prompt().

chrome/browser/banners/app_banner_data_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_data_fetcher.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 170 matching lines @@
   // called if a redisplay isn't asked for.
   //
   // The redisplay request may be received before the Cancel prompt reply
   // *after* if it is made before the beforeinstallprompt event handler
   // concludes (e.g. in the event handler itself), so allow the pipeline
   // to continue in this case.
   //
   // Stash the referrer for the case where the banner is redisplayed.
   if (reply == blink::WebAppBannerPromptReply::Cancel &&
       !page_requested_prompt_) {
+    TrackDisplayEvent(DISPLAY_EVENT_CANCELED_BY_PAGE);
     was_canceled_by_page_ = true;
     referrer_ = referrer;
     OutputDeveloperNotShownMessage(web_contents, kRendererRequestCancel,
                                    is_debug_mode_);
     return;
   }
 
   AppBannerSettingsHelper::RecordMinutesFromFirstVisitToShow(
       web_contents, validated_url_, GetAppIdentifier(), GetCurrentTime());
 
   // Definitely going to show the banner now.
   FOR_EACH_OBSERVER(Observer, observer_list_,
                     OnDecidedWhetherToShow(this, true));
 
   ShowBanner(app_icon_.get(), app_title_, referrer);
   is_active_ = false;
 }
 
 void AppBannerDataFetcher::OnRequestShowAppBanner(
     content::RenderFrameHost* render_frame_host,
     int request_id) {
   if (was_canceled_by_page_) {
     // Simulate an "OK" from the website to restart the banner display pipeline.
     was_canceled_by_page_ = false;
+    TrackDisplayEvent(DISPLAY_EVENT_PROMPTED_BY_PAGE);
     OnBannerPromptReply(render_frame_host, request_id,
                         blink::WebAppBannerPromptReply::None, referrer_);
   } else {
     // Log that the prompt request was made for when we get the prompt reply.
     page_requested_prompt_ = true;

[benwells, 2016/07/05 02:56:20]

Should we also track something here?

[dominickn, 2016/07/05 03:15:33]

Good catch. The BeforeInstallPromptEvent should ensure that this method is only
called when valid, so it's fine to track the metric outside the conditional.

   }
 }
 
 AppBannerDataFetcher::~AppBannerDataFetcher() {
   FOR_EACH_OBSERVER(Observer, observer_list_, OnFetcherDestroyed(this));
 }
 
 std::string AppBannerDataFetcher::GetBannerType() {
   return "web";
 }
@@ skipping 249 matching lines @@
 
   if (!DoesManifestContainRequiredIcon(manifest)) {
     OutputDeveloperNotShownMessage(web_contents, kManifestMissingSuitableIcon,
                                    is_debug_mode);
     return false;
   }
   return true;
 }
 
 }  // namespace banners