Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 2122773002: Skip past nested empty inlines at the start of lines (Closed)

Created:
4 years, 5 months ago by rhogan
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@467579
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip past nested empty inlines at the start of lines BUG=493077 Committed: https://crrev.com/bb390dceca8ea2754bcfd0691699323cddcf2e51 Cr-Commit-Position: refs/heads/master@{#403833}

Patch Set 1 #

Patch Set 2 : bug 493077 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/inline/leading-space-after-nested-empty-inlines.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/inline/leading-space-after-nested-empty-inlines-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rhogan
4 years, 5 months ago (2016-07-05 19:18:58 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-07-05 22:58:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122773002/20001
4 years, 5 months ago (2016-07-05 23:20:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 00:34:24 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 00:36:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb390dceca8ea2754bcfd0691699323cddcf2e51
Cr-Commit-Position: refs/heads/master@{#403833}

Powered by Google App Engine
This is Rietveld 408576698