Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2122763002: This patch removes the need to add MAYBE lines for nearly every test that goes into find_request_ma… (Closed)

Created:
4 years, 5 months ago by paulmeyer
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small optimization in disabling tests on Android Release in find_request_manager_browsertest.cc. This patch removes the need to add MAYBE lines for nearly every test that goes into find_request_manager_browsertest.cc. It does this by defining a MAYBE() function instead of MAYBE/DISABLED definitions for every test name. BUG=615291 Committed: https://crrev.com/cc9a00f96ebe2ec23c1626e5e42de5313e968ef7 Cr-Commit-Position: refs/heads/master@{#403898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M content/browser/find_request_manager_browsertest.cc View 7 chunks +10 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
paulmeyer
4 years, 5 months ago (2016-07-04 19:28:39 UTC) #2
paulmeyer
4 years, 5 months ago (2016-07-04 19:29:01 UTC) #3
jochen (gone - plz use gerrit)
can you please reformat the CL description to match https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list-descriptions and reference the bug 615291? ...
4 years, 5 months ago (2016-07-05 14:18:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122763002/1
4 years, 5 months ago (2016-07-06 13:13:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 13:44:40 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:46:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc9a00f96ebe2ec23c1626e5e42de5313e968ef7
Cr-Commit-Position: refs/heads/master@{#403898}

Powered by Google App Engine
This is Rietveld 408576698