Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2122743004: Use the actual frame for printing single values from the cli debugger. (Closed)

Created:
4 years, 5 months ago by sigurdm
Modified:
4 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
dartino-code-reviews_googlegroups.com
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the actual frame for printing single values from the cli debugger. This closes issue #565 R=sgjesse@google.com Committed: https://github.com/dartino/sdk/commit/c477ef80343d5e6bd3452c93e12f7d21d55e2e2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/dartino_compiler/lib/cli_debugger.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/internal_scope_expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/debugger/internal_scope_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sigurdm
4 years, 5 months ago (2016-07-05 10:21:12 UTC) #2
Søren Gjesse
lgtm
4 years, 5 months ago (2016-07-05 10:25:58 UTC) #3
sigurdm
4 years, 5 months ago (2016-07-05 10:28:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c477ef80343d5e6bd3452c93e12f7d21d55e2e2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698