Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212273002: Move UpdateShortcutInfoAndIconForApp from web_app_ui to web_app (Closed)

Created:
6 years, 9 months ago by jackhou1
Modified:
6 years, 8 months ago
Reviewers:
cmp, benwells, Matt Giuca, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move UpdateShortcutInfoAndIconForApp from web_app_ui to web_app There's no particular need for this to be in web_app_ui. It's better to unify this code into web_app.cc. This refactor is necessary for http://crrev.com/205563005. BUG=356889 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260830

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO #

Patch Set 3 : Restore some #includes #

Patch Set 4 : Fix build on linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -153 lines) Patch
M apps/app_shim/extension_app_shim_handler_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/apps/shortcut_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.h View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 1 2 4 chunks +1 line, -127 lines 0 comments Download
M chrome/browser/web_applications/web_app.h View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 2 3 3 chunks +123 lines, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 41 (0 generated)
jackhou1
6 years, 9 months ago (2014-03-26 06:49:21 UTC) #1
Matt Giuca
lgtm, assuming all the green bits are the same as the red bits! :)
6 years, 9 months ago (2014-03-26 22:47:59 UTC) #2
jackhou1
benwells, please review for OWNERS sky, please review for OWNERS in chrome/browser/ui/
6 years, 9 months ago (2014-03-26 22:56:55 UTC) #3
benwells
https://codereview.chromium.org/212273002/diff/1/chrome/browser/ui/web_applications/web_app_ui.cc File chrome/browser/ui/web_applications/web_app_ui.cc (right): https://codereview.chromium.org/212273002/diff/1/chrome/browser/ui/web_applications/web_app_ui.cc#newcode39 chrome/browser/ui/web_applications/web_app_ui.cc:39: #if defined(OS_WIN) Can we kill this entire file? Seems ...
6 years, 9 months ago (2014-03-26 23:50:21 UTC) #4
jackhou1
https://codereview.chromium.org/212273002/diff/1/chrome/browser/ui/web_applications/web_app_ui.cc File chrome/browser/ui/web_applications/web_app_ui.cc (right): https://codereview.chromium.org/212273002/diff/1/chrome/browser/ui/web_applications/web_app_ui.cc#newcode39 chrome/browser/ui/web_applications/web_app_ui.cc:39: #if defined(OS_WIN) On 2014/03/26 23:50:21, benwells wrote: > Can ...
6 years, 9 months ago (2014-03-27 00:03:56 UTC) #5
benwells
lgtm with a TODO to move the rest of the stuff.
6 years, 9 months ago (2014-03-27 00:54:27 UTC) #6
sky
LGTM
6 years, 8 months ago (2014-03-27 15:39:12 UTC) #7
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-03-27 23:21:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/60001
6 years, 8 months ago (2014-03-27 23:23:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 00:39:08 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=165540 Try jobs failed on ...
6 years, 8 months ago (2014-03-28 00:39:09 UTC) #11
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-03-28 01:31:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-03-28 01:32:46 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 02:47:07 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 8 months ago (2014-03-28 02:47:08 UTC) #15
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-03-28 05:35:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-03-28 05:36:05 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 09:38:08 UTC) #18
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137003
6 years, 8 months ago (2014-03-28 09:38:08 UTC) #19
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-03-28 11:12:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-03-28 11:12:25 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 16:39:27 UTC) #22
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137397
6 years, 8 months ago (2014-03-28 16:39:27 UTC) #23
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-03-29 06:09:06 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-03-29 06:20:54 UTC) #25
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 18:18:35 UTC) #26
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 18:32:19 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-03-30 18:32:27 UTC) #28
jackhou1
The CQ bit was unchecked by jackhou@chromium.org
6 years, 8 months ago (2014-03-31 00:07:06 UTC) #29
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-03-31 00:07:08 UTC) #30
jackhou1
The CQ bit was unchecked by jackhou@chromium.org
6 years, 8 months ago (2014-04-01 02:02:53 UTC) #31
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-04-01 02:03:20 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-04-01 02:04:06 UTC) #33
jackhou1
The CQ bit was unchecked by jackhou@chromium.org
6 years, 8 months ago (2014-04-01 03:36:24 UTC) #34
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-04-01 05:14:00 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-04-01 05:14:12 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 06:03:56 UTC) #37
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=291767
6 years, 8 months ago (2014-04-01 06:03:57 UTC) #38
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-04-01 08:57:08 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/212273002/80001
6 years, 8 months ago (2014-04-01 08:57:35 UTC) #40
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 11:17:45 UTC) #41
Message was sent while issue was closed. 
Change committed as 260830

Powered by Google App Engine
This is Rietveld 408576698