Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2122713002: unbundle: add GN files for libpng, libvpx, and re2 (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -21 lines) Patch
A + build/linux/unbundle/libpng.gn View 1 chunk +8 lines, -13 lines 0 comments Download
A build/linux/unbundle/libvpx.gn View 1 chunk +34 lines, -0 lines 0 comments Download
A + build/linux/unbundle/re2.gn View 1 chunk +9 lines, -8 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-04 16:18:45 UTC) #2
jochen (gone - plz use gerrit)
rubber-stamp lgtm
4 years, 5 months ago (2016-07-05 14:16:27 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f499ac9faf8d6919045f8e6c2c46b2e9d452f714 Cr-Commit-Position: refs/heads/master@{#403785}
4 years, 5 months ago (2016-07-05 16:02:06 UTC) #5
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-05 16:03:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f499ac9faf8d6919045f8e6c2c46b2e9d452f714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698