[telemetry] Add support for dispatching key events

[telemetry] Add support for dispatching key events

This enables stories to simulate key presses, e.g.:

  action_runner.PressKey('PageDown')
  action_runner.EnterText('This text will be added char-by-char.')

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/aad076ce2d0def58657d3a31c264bc41b6cfaa07

[petrcermak, 2016-07-04 16:04:42]

Patchset #1 (id:1) has been deleted

[petrcermak, 2016-07-04 16:06:03]

Description was changed from

==========
[telemetry] Add support for dispatching key events

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726
==========

to

==========
[telemetry] Add support for dispatching key events

This enables stories to simulate key presses, e.g.:

  action_runner.PressKey('PageDown')

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726
==========

[petrcermak, 2016-07-04 16:08:41]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com, sullivan@chromium.org

[petrcermak, 2016-07-04 16:08:42]

PTAL.

Thanks,
Petr

[nednguyen, 2016-07-05 12:41:03]

mostly l2gm

Can you add test to action_runner_unittest to cover new API?

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/actions/action_runner.py (right):

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:577: """
can you raise ValueError for invalid value of "key"?

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:579: 
Maybe we should add another helper method like "EnterText(self, text,
chars_per_second)". What do you think?

[nednguyen, 2016-07-05 13:17:34]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org

[nednguyen, 2016-07-05 13:17:34]

lgtm whenever Kari is happy

[petrcermak, 2016-07-06 16:32:49]

Patchset #2 (id:40001) has been deleted

[petrcermak, 2016-07-06 16:34:51]

Description was changed from

==========
[telemetry] Add support for dispatching key events

This enables stories to simulate key presses, e.g.:

  action_runner.PressKey('PageDown')

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726
==========

to

==========
[telemetry] Add support for dispatching key events

This enables stories to simulate key presses, e.g.:

  action_runner.PressKey('PageDown')
  action_runner.EnterText('This text will be added char-by-char.')

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726
==========

[petrcermak, 2016-07-06 16:35:05]

Thanks for your comments. PTAL.

Petr

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/actions/action_runner.py (right):

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:577: """
On 2016/07/05 12:41:02, nednguyen (ooo til 7-11) wrote:
> can you raise ValueError for invalid value of "key"?

A KeyError is already thrown for invalid values of "key" (in the dict lookup).
If you want, I can make the error explicit.

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:579: 
On 2016/07/05 12:41:02, nednguyen (ooo til 7-11) wrote:
> Maybe we should add another helper method like "EnterText(self, text,
> chars_per_second)". What do you think?

I completely agree. Done.

Note that I used |character_delay_ms| instead of |chars_per_second| because it's
more consistent with the signatures of the other methods in the class.

[nednguyen, 2016-07-07 02:43:27]

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/actions/action_runner.py (right):

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:577: """
On 2016/07/06 16:35:05, petrcermak wrote:
> On 2016/07/05 12:41:02, nednguyen (ooo til 7-11) wrote:
> > can you raise ValueError for invalid value of "key"?
> 
> A KeyError is already thrown for invalid values of "key" (in the dict lookup).
> If you want, I can make the error explicit.

Since this a pubic API, an explicit error raised inside PressKey  will make
users less confused by the internal implementation.

[petrcermak, 2016-07-07 15:25:57]

Thanks for your comments. PTAL.

Petr

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/actions/action_runner.py (right):

https://codereview.chromium.org/2122703002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/actions/action_runner.py:577: """
On 2016/07/07 02:43:27, nednguyen (ooo til 7-11) wrote:
> On 2016/07/06 16:35:05, petrcermak wrote:
> > On 2016/07/05 12:41:02, nednguyen (ooo til 7-11) wrote:
> > > can you raise ValueError for invalid value of "key"?
> > 
> > A KeyError is already thrown for invalid values of "key" (in the dict
lookup).
> > If you want, I can make the error explicit.
> 
> Since this a pubic API, an explicit error raised inside PressKey  will make
> users less confused by the internal implementation.

Done.

[nednguyen, 2016-07-07 20:59:51]

lgtm

[aiolos (Not reviewing), 2016-07-08 22:47:12]

lgtm

[petrcermak, 2016-07-11 07:25:22]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-11 07:25:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 07:56:32]

Description was changed from

==========
[telemetry] Add support for dispatching key events

This enables stories to simulate key presses, e.g.:

  action_runner.PressKey('PageDown')
  action_runner.EnterText('This text will be added char-by-char.')

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726
==========

to

==========
[telemetry] Add support for dispatching key events

This enables stories to simulate key presses, e.g.:

  action_runner.PressKey('PageDown')
  action_runner.EnterText('This text will be added char-by-char.')

Rationale: This will allow us to write more complex System Health user
stories.

BUG=chromium:589726

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-11 07:56:33]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[eakuefner, 2016-07-11 20:36:52]

A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/2137243002/ by eakuefner@chromium.org.

The reason for reverting is: Broke Catapult roll: crbug.com/627221 for context..