Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2122643003: MIPS: Fix '[turbofan]: Support using push instructions for setting up tail call parameters' (Closed)

Created:
4 years, 5 months ago by akos.palfi.imgtec
Modified:
4 years, 5 months ago
Reviewers:
balazs.kilvady, danno
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix '[turbofan]: Support using push instructions for setting up tail call parameters' Port bd0d9e7d87d418b0c6a84f298e27058645083dad BUG= Committed: https://crrev.com/5e8ba681989195990c07d87126b7089ff96dbc2a Cr-Commit-Position: refs/heads/master@{#37499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
akos.palfi.imgtec
Typo fixes, PTAL.
4 years, 5 months ago (2016-07-04 12:10:46 UTC) #2
balazs.kilvady
lgtm
4 years, 5 months ago (2016-07-04 12:13:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122643003/1
4 years, 5 months ago (2016-07-04 12:14:39 UTC) #5
danno
Thanks for fixing this!
4 years, 5 months ago (2016-07-04 12:19:59 UTC) #6
danno
Oh, btw, this probably needs to be merged to M53.
4 years, 5 months ago (2016-07-04 12:20:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 12:37:44 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 12:37:48 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 12:40:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e8ba681989195990c07d87126b7089ff96dbc2a
Cr-Commit-Position: refs/heads/master@{#37499}

Powered by Google App Engine
This is Rietveld 408576698