Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2122643002: X87: [builtins] Unify most of the remaining Math builtins. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Unify most of the remaining Math builtins. port 0a0fe8fb8b06d5e90b082838739ebf44cab04028 (r37476) original commit message: Import fdlibm versions of acos, acosh, asin and asinh, which are more precise and produce the same result across platforms (we were using libm versions for asin and acos so far, where both speed and precision depended on the operating system so far). Introduce appropriate TurboFan operators for these functions and use them both for inlining and for the generic builtin. Also migrate the Math.imul and Math.fround builtins to TurboFan builtins to ensure that their behavior is always exactly the same as the inlined TurboFan version (i.e. C++ truncation semantics for double to float don't necessarily meet the JavaScript semantics). For completeness, also migrate Math.sign, which can even get some nice love in TurboFan. Drive-by-fix: Some alpha-sorting on the Math related functions, and cleanup the list of Math intrinsics that we have to export via the native context currently. BUG= Committed: https://crrev.com/4f7f6aee3f7dbf0735bd3c082d067158d60b69be Cr-Commit-Position: refs/heads/master@{#37496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 09:41:06 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-04 09:42:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122643002/1
4 years, 5 months ago (2016-07-04 09:43:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 10:04:42 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 10:04:43 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 10:05:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f7f6aee3f7dbf0735bd3c082d067158d60b69be
Cr-Commit-Position: refs/heads/master@{#37496}

Powered by Google App Engine
This is Rietveld 408576698