Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 212263002: remove use of {,un}setPendingActivity from DOMFileSystem. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
CC:
blink-reviews, nhiroki, tzik
Visibility:
Public.

Description

remove use of {,un}setPendingActivity from DOMFileSystem. {,un}setPendingActivity is deprecated. This CL replaces it with |hasPendingActivity()| override. This also makes FileSystemCallbacks reference to the DOMFileSystem strong, as |addPendingCallbacks()| would no longer ref() DOMFileSystem. TEST=fast/filesystem BUG=354845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M Source/modules/filesystem/DOMFileSystem.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystem.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/filesystem/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
kouhei (in TOK)
6 years, 9 months ago (2014-03-26 06:44:09 UTC) #1
kouhei (in TOK)
6 years, 9 months ago (2014-03-26 06:44:10 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-26 06:49:09 UTC) #3
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-26 08:45:18 UTC) #4
zerny-chromium
lgtm
6 years, 9 months ago (2014-03-26 09:16:33 UTC) #5
kouhei (in TOK)
kinuko: Would you also take a look?
6 years, 9 months ago (2014-03-26 09:17:41 UTC) #6
kinuko
On 2014/03/26 09:17:41, kouhei wrote: > kinuko: Would you also take a look? lgtm, sorry ...
6 years, 9 months ago (2014-03-26 11:59:15 UTC) #7
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 12:14:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/212263002/1
6 years, 9 months ago (2014-03-26 12:14:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 12:25:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-26 12:25:12 UTC) #11
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 12:33:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/212263002/1
6 years, 9 months ago (2014-03-26 12:33:39 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 12:58:28 UTC) #14
Message was sent while issue was closed.
Change committed as 170052

Powered by Google App Engine
This is Rietveld 408576698