Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2122613002: Add a use counter for author rules setting display: block on summary. (Closed)

Created:
4 years, 5 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh, rkaplow
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use counter for author rules setting display: block on summary. The HTML spec says to use list-item rendering to display the summary element. This lets authors control how the disclosure triangle is rendered with list-style-type, etc. Today, Chromium uses display: block for the summary element. Changing to list-item would mean authors who set display: block on summary will not see the disclosure triangle any more. This patch adds a use counter for pages which set display: block on summary in author rules. BUG=590014 Committed: https://crrev.com/14ef05cd9985903f9d239853dd0b2479aa70914c Cr-Commit-Position: refs/heads/master@{#403848}

Patch Set 1 #

Patch Set 2 : Bring patch to head. #

Patch Set 3 : Bring patch to head. Update counter value in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/usecounter-summary-display-block.html View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 5 months ago (2016-07-04 07:31:17 UTC) #2
rkaplow
lgtm histogram lg
4 years, 5 months ago (2016-07-04 14:48:07 UTC) #3
Timothy Loh
lgtm, but this should also catch inline styles and whatnot, contrary to what you've written ...
4 years, 5 months ago (2016-07-05 00:44:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122613002/1
4 years, 5 months ago (2016-07-05 01:00:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/254751)
4 years, 5 months ago (2016-07-05 01:04:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122613002/20001
4 years, 5 months ago (2016-07-05 06:40:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/257168)
4 years, 5 months ago (2016-07-05 08:03:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122613002/40001
4 years, 5 months ago (2016-07-06 01:20:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/31580)
4 years, 5 months ago (2016-07-06 01:25:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122613002/40001
4 years, 5 months ago (2016-07-06 02:24:37 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 04:03:14 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 04:03:18 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 04:05:57 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14ef05cd9985903f9d239853dd0b2479aa70914c
Cr-Commit-Position: refs/heads/master@{#403848}

Powered by Google App Engine
This is Rietveld 408576698