Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2122603004: [heap] Track length for array buffers to avoid free-ing dependency (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Track length for array buffers to avoid free-ing dependency The dependency would only happen if we have a smi overflow for the length and have create a heap number. In this case the heap number would've to survive until the array buffer is collected. To avoid this dependency we track the length (as we previously used to). BUG=chromium:625748, chromium:625752 LOG=N TEST=test/mjsunit/regress/regress-625752.js R=hpayer@chromium.org Committed: https://crrev.com/ddc75cc1356a58b6cfd63f9da0586e1150496b3d Cr-Commit-Position: refs/heads/master@{#37530}

Patch Set 1 #

Patch Set 2 : fix exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M src/heap/array-buffer-tracker.h View 4 chunks +5 lines, -4 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 2 chunks +8 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-625752.js View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122603004/1
4 years, 5 months ago (2016-07-05 09:35:27 UTC) #2
Michael Lippautz
4 years, 5 months ago (2016-07-05 09:35:44 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/4427) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 5 months ago (2016-07-05 09:53:18 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122603004/20001
4 years, 5 months ago (2016-07-05 10:03:09 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-05 10:31:02 UTC) #11
Hannes Payer (out of office)
lgtm
4 years, 5 months ago (2016-07-05 13:02:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122603004/20001
4 years, 5 months ago (2016-07-05 13:12:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 13:14:41 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ddc75cc1356a58b6cfd63f9da0586e1150496b3d Cr-Commit-Position: refs/heads/master@{#37530}
4 years, 5 months ago (2016-07-05 13:15:29 UTC) #18
Michael Achenbach
4 years, 5 months ago (2016-07-05 14:40:46 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2127483003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This makes mjsunit/regress/regress-625752
extremely slow on all gc stress bots and leads to timeouts with custom snapshot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20....

Powered by Google App Engine
This is Rietveld 408576698