Refactor the barback tests somewhat.

pkg/barback/test/asset_set_test.dart

Index: pkg/barback/test/asset_set_test.dart
diff --git a/pkg/barback/test/asset_set_test.dart b/pkg/barback/test/asset_set_test.dart
index 6cb1eb8385814636cf3d0b69f154c9fe218399b5..637485dc7ac519dbd37b043b368a62d07bf95c06 100644
--- a/pkg/barback/test/asset_set_test.dart
+++ b/pkg/barback/test/asset_set_test.dart
@@ -18,11 +18,25 @@ main() {
 
   var fooId = new AssetId.parse("app|foo.txt");
   var barId = new AssetId.parse("app|bar.txt");
+  var bazId = new AssetId.parse("app|baz.txt");
+
+  group(".from()", () {
+    test("creates a set from an iterable", () {
+      var set = new AssetSet.from([
+        new Asset.fromString(fooId, "foo"),
+        new Asset.fromString(barId, "bar")
+      ]);
+
+      expect(set.containsId(fooId), isTrue);
+      expect(set.containsId(barId), isTrue);
+      expect(set.containsId(bazId), isFalse);
+    });
+  });
 
   group("[] operator", () {
     test("gets an asset with the given ID", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
+      var foo = new Asset.fromString(fooId, "foo");
       set.add(foo);
 
       expect(set[fooId], equals(foo));
@@ -37,21 +51,21 @@ main() {
   group(".add()", () {
     test("adds the asset to the set", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
+      var foo = new Asset.fromString(fooId, "foo");
       set.add(foo);
       expect(set.contains(foo), isTrue);
     });
 
     test("replaces a previously added asset with that ID", () {
       var set = new AssetSet();
-      set.add(new MockAsset(fooId, "before"));
-      set.add(new MockAsset(fooId, "after"));
-      expect(set[fooId].contents, equals("after"));
+      set.add(new Asset.fromString(fooId, "before"));
+      set.add(new Asset.fromString(fooId, "after"));
+      expect(set[fooId].readAsString(), completion(equals("after")));
     });
 
     test("returns the added item", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
+      var foo = new Asset.fromString(fooId, "foo");
       expect(set.add(foo), equals(foo));
     });
   });
@@ -59,8 +73,8 @@ main() {
   group(".addAll()", () {
     test("adds the assets to the set", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
-      var bar = new MockAsset(barId, "bar");
+      var foo = new Asset.fromString(fooId, "foo");
+      var bar = new Asset.fromString(barId, "bar");
       set.addAll([foo, bar]);
       expect(set.contains(foo), isTrue);
       expect(set.contains(bar), isTrue);
@@ -68,17 +82,17 @@ main() {
 
     test("replaces assets earlier in the sequence with later ones", () {
       var set = new AssetSet();
-      var foo1 = new MockAsset(fooId, "before");
-      var foo2 = new MockAsset(fooId, "after");
+      var foo1 = new Asset.fromString(fooId, "before");
+      var foo2 = new Asset.fromString(fooId, "after");
       set.addAll([foo1, foo2]);
-      expect(set[fooId].contents, equals("after"));
+      expect(set[fooId].readAsString(), completion(equals("after")));
     });
   });
 
   group(".clear()", () {
     test("empties the set", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
+      var foo = new Asset.fromString(fooId, "foo");
       set.add(foo);
       set.clear();
 
@@ -90,8 +104,8 @@ main() {
   group(".contains()", () {
     test("returns true if the asset is in the set", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
-      var bar = new MockAsset(barId, "bar");
+      var foo = new Asset.fromString(fooId, "foo");
+      var bar = new Asset.fromString(barId, "bar");
       set.add(foo);
 
       expect(set.contains(foo), isTrue);
@@ -102,11 +116,23 @@ main() {
   group(".containsId()", () {
     test("returns true if an asset with the ID is in the set", () {
       var set = new AssetSet();
-      var foo = new MockAsset(fooId, "foo");
+      var foo = new Asset.fromString(fooId, "foo");
       set.add(foo);
 
       expect(set.containsId(fooId), isTrue);
       expect(set.containsId(barId), isFalse);
     });
   });
+
+  group(".removeId()", () {
+    test("removes the asset with the ID from the set", () {

[Bob Nystrom, 2013/07/30 22:25:02]

Test removing a non-present asset.

[nweiz, 2013/07/30 22:46:21]

Done.

+      var set = new AssetSet();
+      var foo = new Asset.fromString(fooId, "foo");
+      set.add(foo);
+
+      expect(set.removeId(fooId).readAsString(), completion(equals("foo")));

[Bob Nystrom, 2013/07/30 22:25:02]

Make "returns the removed Asset" a separate test.

[nweiz, 2013/07/30 22:46:21]

Done.

+      expect(set.containsId(fooId), isFalse);
+      expect(set.removeId(barId), isNull);
+    });
+  });
 }