Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: media/renderers/skcanvas_video_renderer.cc

Issue 2122573003: media: replace LUMINANCE_F16 by RG_88 for 9/10-bit h264 videos Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: introduce --disable-half-float-conversion-texture flag Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/skcanvas_video_renderer.cc
diff --git a/media/renderers/skcanvas_video_renderer.cc b/media/renderers/skcanvas_video_renderer.cc
index 3ff3510a992dd99c35f35aec43f1c262dbc8aa34..7941dc0028e2e212bebbbac965768d70d8153a58 100644
--- a/media/renderers/skcanvas_video_renderer.cc
+++ b/media/renderers/skcanvas_video_renderer.cc
@@ -610,6 +610,12 @@ void SkCanvasVideoRenderer::ConvertVideoFrameToRGBPixels(
case PIXEL_FORMAT_RGB32:
case PIXEL_FORMAT_MJPEG:
case PIXEL_FORMAT_MT21:
+ // TODO(dshwang): Use either I400ToARGB or J400ToARGB depending if we want
+ // BT.601 constrained range of 16 to 240, or JPEG full range BT.601
+ // coefficients. Implement it when Y8/16 foramt is supported.
+ // crbug.com/624436
+ case PIXEL_FORMAT_Y8:
+ case PIXEL_FORMAT_Y16:
case PIXEL_FORMAT_UNKNOWN:
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698