Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2122573002: Correct alignment in ContiguousContainer::appendByMoving() (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
jbroman, enne (OOO)
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct alignment in ContiguousContainer::appendByMoving() CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel BUG=625381 TBR=enne@chromium.org (for same change in cc as in blink) Committed: https://crrev.com/d2bdd54edb30daa800142bf0e996eb75cb417e94 Cr-Commit-Position: refs/heads/master@{#403979}

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : 0u #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -12 lines) Patch
M cc/base/contiguous_container.h View 1 2 chunks +9 lines, -4 lines 0 comments Download
M cc/base/contiguous_container_unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.h View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainerTest.cpp View 1 1 chunk +28 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (11 generated)
Xianzhu
4 years, 5 months ago (2016-07-05 04:41:32 UTC) #3
jbroman
lgtm
4 years, 5 months ago (2016-07-05 13:57:04 UTC) #4
jbroman
(BTW, aren't yesterday and today supposed to be holidays in US?)
4 years, 5 months ago (2016-07-05 13:57:48 UTC) #5
jbroman
Oh. Please add BUG=625381 to the description.
4 years, 5 months ago (2016-07-05 13:58:15 UTC) #6
Xianzhu
On 2016/07/05 13:57:48, jbroman wrote: > (BTW, aren't yesterday and today supposed to be holidays ...
4 years, 5 months ago (2016-07-06 16:43:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122573002/40001
4 years, 5 months ago (2016-07-06 16:43:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99070)
4 years, 5 months ago (2016-07-06 18:42:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122573002/40001
4 years, 5 months ago (2016-07-06 18:46:10 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99201)
4 years, 5 months ago (2016-07-06 22:12:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122573002/40001
4 years, 5 months ago (2016-07-06 22:15:56 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 23:37:42 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:37:48 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:39:32 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2bdd54edb30daa800142bf0e996eb75cb417e94
Cr-Commit-Position: refs/heads/master@{#403979}

Powered by Google App Engine
This is Rietveld 408576698