[Hotword] Update helper extension to listen for change to audio logging preference.

chrome/browser/resources/hotword_helper/optin_client.js

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview This is the content script injected by the opt in helper.
  *   It is injected into the newtab page and also google.com and notifies the
  *   page to show an opt-in message for the user to enable the built-in hotword
@@ skipping 17 matching lines @@
 
 
 /**
  * Commands sent from the page to this content script.
  * @enum {string}
  */
 OptInClient.CommandFromPage = {
   // User has explicitly clicked 'no'.
   CLICKED_NO_OPTIN: 'hcno',
   // User has opted in.
-  CLICKED_OPTIN: 'hco'
+  CLICKED_OPTIN: 'hco',
+  // Audio logging is opted in.
+  AUDIO_LOGGING_ON: 'alon',
+  // Audio logging is opted out.
+  AUDIO_LOGGING_OFF: 'aloff',
 };
 
 
 /**
  * Used to determine if this content script has already been injected.
  * @const {string}
  * @private
  */
 OptInClient.EXISTS_ = 'chwoihe';
 
 
 /**
  * Handles the messages posted to the window, mainly listening for
- * the optin and no optin clicks.
+ * the optin and no optin clicks. Also listening for preference on
+ * audio logging.
  * @param {!MessageEvent} messageEvent Message event from the window.
  * @private
  */
 OptInClient.prototype.handleCommandFromPage_ = function(messageEvent) {
   if (messageEvent.source === window && messageEvent.data.type) {
     var command = messageEvent.data.type;
     switch (command) {
       case OptInClient.CommandFromPage.CLICKED_OPTIN:
         chrome.runtime.sendMessage(
             {'type': command});
         break;
       case OptInClient.CommandFromPage.CLICKED_NO_OPTIN:
         chrome.runtime.sendMessage(
             {'type': command});
         break;
+      case OptInClient.CommandFromPage.AUDIO_LOGGING_ON:
+        chrome.runtime.sendMessage(
+            {'type': command});
+        break;
+      case OptInClient.CommandFromPage.AUDIO_LOGGING_OFF:
+        chrome.runtime.sendMessage(
+            {'type': command});

[saurya1, 2014/03/27 16:29:22]

If you want to clean this up you can just remove the
chrome.runtime.sendMessage() and breaks above and have a default case that just
passes on the message.

[rpetterson, 2014/03/27 16:37:19]

I assume I don't actually need the switch statement anymore? I think I've
cleaned it up, but PTAL.

+        break;
     }
   }
 };
 
 
 /**
  * Sends a command to the page allowing it to display the hotword opt-in
  * message. It is up to the page whether it is actually displayed.
  * @private
  */
@@ skipping 16 matching lines @@
       'message', this.handleCommandFromPage_.bind(this), false);
 
   if (document.readyState === 'complete')
     this.notifyPageAllowOptIn_();
   else
     document.onreadystatechange = this.notifyPageAllowOptIn_;
 };
 
 
 new OptInClient().initialize();