Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 212253003: [Hotword] Update helper extension to listen for change to audio logging preference. (Closed)

Created:
6 years, 9 months ago by rpetterson
Modified:
6 years, 9 months ago
Reviewers:
saurya1, James Hawkins
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

[Hotword] Update helper extension to listen for change to audio logging preference. Helper extension then notifies chrome and tells the extension to turn on/off. BUG=345811 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260195

Patch Set 1 #

Patch Set 2 : send message to extension #

Total comments: 4

Patch Set 3 : fix typo, cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M chrome/browser/resources/hotword_helper/manager.js View 1 2 2 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/resources/hotword_helper/optin_client.js View 1 2 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
saurya1
https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources/hotword_helper/manager.js File chrome/browser/resources/hotword_helper/manager.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources/hotword_helper/manager.js#newcode171 chrome/browser/resources/hotword_helper/manager.js:171: {'cmd': OptInManager.CommandFromHelper.AUDIO_LOGGING_OFF}); AUDIO_LOGGING_ON https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources/hotword_helper/optin_client.js File chrome/browser/resources/hotword_helper/optin_client.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources/hotword_helper/optin_client.js#newcode79 chrome/browser/resources/hotword_helper/optin_client.js:79: ...
6 years, 9 months ago (2014-03-27 16:29:22 UTC) #1
rpetterson
https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources/hotword_helper/manager.js File chrome/browser/resources/hotword_helper/manager.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources/hotword_helper/manager.js#newcode171 chrome/browser/resources/hotword_helper/manager.js:171: {'cmd': OptInManager.CommandFromHelper.AUDIO_LOGGING_OFF}); On 2014/03/27 16:29:22, saurya1 wrote: > AUDIO_LOGGING_ON ...
6 years, 9 months ago (2014-03-27 16:37:18 UTC) #2
saurya1
lgtm
6 years, 9 months ago (2014-03-27 21:55:10 UTC) #3
rpetterson
For owners approval.
6 years, 9 months ago (2014-03-27 21:56:24 UTC) #4
rpetterson
Actually adding James for owners approval this time.
6 years, 9 months ago (2014-03-27 21:57:04 UTC) #5
James Hawkins
lgtm
6 years, 9 months ago (2014-03-27 21:58:54 UTC) #6
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 9 months ago (2014-03-28 00:41:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
6 years, 9 months ago (2014-03-28 00:43:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 02:53:56 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 9 months ago (2014-03-28 02:53:57 UTC) #10
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 9 months ago (2014-03-28 03:34:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
6 years, 9 months ago (2014-03-28 03:34:57 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 04:35:06 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136702
6 years, 9 months ago (2014-03-28 04:35:07 UTC) #14
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 9 months ago (2014-03-28 05:04:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
6 years, 9 months ago (2014-03-28 05:06:08 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 09:28:05 UTC) #17
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) components_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136994
6 years, 9 months ago (2014-03-28 09:28:05 UTC) #18
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 9 months ago (2014-03-28 15:32:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
6 years, 9 months ago (2014-03-28 15:33:03 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:08:59 UTC) #21
Message was sent while issue was closed.
Change committed as 260195

Powered by Google App Engine
This is Rietveld 408576698