|
|
Created:
6 years, 9 months ago by rpetterson Modified:
6 years, 9 months ago CC:
chromium-reviews, arv+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Description[Hotword] Update helper extension to listen for change to audio logging preference.
Helper extension then notifies chrome and tells the extension to turn on/off.
BUG=345811
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260195
Patch Set 1 #Patch Set 2 : send message to extension #
Total comments: 4
Patch Set 3 : fix typo, cleanup #
Messages
Total messages: 21 (0 generated)
https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... File chrome/browser/resources/hotword_helper/manager.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... chrome/browser/resources/hotword_helper/manager.js:171: {'cmd': OptInManager.CommandFromHelper.AUDIO_LOGGING_OFF}); AUDIO_LOGGING_ON https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... File chrome/browser/resources/hotword_helper/optin_client.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... chrome/browser/resources/hotword_helper/optin_client.js:79: {'type': command}); If you want to clean this up you can just remove the chrome.runtime.sendMessage() and breaks above and have a default case that just passes on the message.
https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... File chrome/browser/resources/hotword_helper/manager.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... chrome/browser/resources/hotword_helper/manager.js:171: {'cmd': OptInManager.CommandFromHelper.AUDIO_LOGGING_OFF}); On 2014/03/27 16:29:22, saurya1 wrote: > AUDIO_LOGGING_ON Derp. Copy/paste. Fixed. https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... File chrome/browser/resources/hotword_helper/optin_client.js (right): https://codereview.chromium.org/212253003/diff/20001/chrome/browser/resources... chrome/browser/resources/hotword_helper/optin_client.js:79: {'type': command}); I assume I don't actually need the switch statement anymore? I think I've cleaned it up, but PTAL.
lgtm
For owners approval.
Actually adding James for owners approval this time.
lgtm
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests, components_unittests, compositor_unittests, content_browsertests, content_unittests, crypto_unittests, events_unittests, gfx_unittests, google_apis_unittests, gpu_unittests, installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests, media_unittests, mini_installer_test, nacl_integration, net_unittests, ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests, sync_unit_tests, telemetry_perf_unittests, telemetry_unittests, unit_tests, views_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on ios_dbg_simulator for step(s) components_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/212253003/40001
Message was sent while issue was closed.
Change committed as 260195 |