Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2122453002: Delete remove-from-document-no-load.html test (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete remove-from-document-no-load.html test The test case doesn't exactly test what it says (verifying that "loadstart" event is not fired. But resource load algorithm will start as soon as video "src" is set and "loadstart" event will be fired eventually. Removing it as it isn't doing anything useful. BUG=588956 Committed: https://crrev.com/3c62f5896889bce9cc8b847c5b8d204c820ad6ed Cr-Commit-Position: refs/heads/master@{#403612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
D third_party/WebKit/LayoutTests/media/remove-from-document-no-load.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/remove-from-document-no-load-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Srirama
PTAL. This was added more than 7years ago and probably the media loading behaviour was ...
4 years, 5 months ago (2016-07-02 12:00:35 UTC) #4
fs
lgtm
4 years, 5 months ago (2016-07-02 16:54:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122453002/1
4 years, 5 months ago (2016-07-02 16:59:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-02 18:21:16 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-02 18:21:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 18:23:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c62f5896889bce9cc8b847c5b8d204c820ad6ed
Cr-Commit-Position: refs/heads/master@{#403612}

Powered by Google App Engine
This is Rietveld 408576698