Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Issue 2122443002: Add a flag for filtering tests after sharding. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Zhen Wang
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, aiolos (Not reviewing), eakuefner, nednguyen
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add a flag for filtering tests after sharding. Filtering the tests before shards are computed changes how tests are distributed among shards, which makes it difficult to track down bugs which depend on the order in which tests are run. BUG=chromium:625363 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/ea4fad0d8d0f002cfec63a8d2d5697e70b3e5734

Patch Set 1 #

Patch Set 2 : Added unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -25 lines) Patch
M telemetry/telemetry/testing/browser_test_runner.py View 1 5 chunks +18 lines, -3 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner_unittest.py View 1 4 chunks +50 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
Zhen: please review. Thanks. Others: FYI.
4 years, 5 months ago (2016-07-08 19:00:17 UTC) #2
Zhen Wang
lgtm
4 years, 5 months ago (2016-07-08 19:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122443002/20001
4 years, 5 months ago (2016-07-08 20:44:20 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:46:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698