third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h - Issue 2122423002: [DevTools] Remove functionDetails from protocol.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

Issue 2122423002: [DevTools] Remove functionDetails from protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

index 9a2582416a34a454cd4340110187b7046ea3f8ef..bf49fa71f40cea9d7aff9bae01e393f054bbc214 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

@@ -21,10 +21,6 @@ public:

// We expect that debugger outlives any JS context and thus V8InjectedScriptHost (owned by JS)

// is destroyed before debugger.

static v8::Local<v8::Object> create(v8::Local<v8::Context>, V8DebuggerImpl*);

- static v8::Local<v8::Private> internalEntryPrivate(v8::Isolate*);

- static v8::Local<v8::Private> internalLocationPrivate(v8::Isolate*);

private:

static void internalConstructorNameCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void formatAccessorsAsProperties(const v8::FunctionCallbackInfo<v8::Value>&);