third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h - Issue 2122423002: [DevTools] Remove functionDetails from protocol.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 2122423002: [DevTools] Remove functionDetails from protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

index fdae2de41ad521f5a6e3426e45d887a8a3ea9832..f1960ccca519106e6d0b301c09eaffbe6e8d9812 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

@@ -92,9 +92,6 @@ public:

std::unique_ptr<protocol::Array<protocol::Debugger::CallFrame>>* newCallFrames,

Maybe<protocol::Runtime::StackTrace>* asyncStackTrace) override;

void getScriptSource(ErrorString*, const String16& scriptId, String16* scriptSource) override;

- void getFunctionDetails(ErrorString*,

- const String16& functionId,

- std::unique_ptr<protocol::Debugger::FunctionDetails>*) override;

void pause(ErrorString*) override;

void resume(ErrorString*) override;

void stepOver(ErrorString*) override;