Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2122423002: [DevTools] Remove functionDetails from protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index f59a6b0d20f6df0bd195612973bb19b63c92062c..a1dd12946d92001c5d91fd87f531f734d75b463c 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -281,31 +281,6 @@ WebInspector.RemoteObject.prototype = {
isNode: function()
{
return false;
- },
-
- /**
- * @param {function(?WebInspector.DebuggerModel.FunctionDetails)} callback
- */
- functionDetails: function(callback)
- {
- callback(null);
- },
-
- /**
- * @return {!Promise<?WebInspector.DebuggerModel.FunctionDetails>}
- */
- functionDetailsPromise: function()
- {
- return new Promise(promiseConstructor.bind(this));
-
- /**
- * @param {function(?WebInspector.DebuggerModel.FunctionDetails)} success
- * @this {WebInspector.RemoteObject}
- */
- function promiseConstructor(success)
- {
- this.functionDetails(success);
- }
}
}
@@ -860,15 +835,6 @@ WebInspector.RemoteObjectImpl.prototype = {
return !!this._objectId && this.type === "object" && this.subtype === "node";
},
- /**
- * @override
- * @param {function(?WebInspector.DebuggerModel.FunctionDetails)} callback
- */
- functionDetails: function(callback)
- {
- this._debuggerModel.functionDetails(this, callback);
- },
-
__proto__: WebInspector.RemoteObject.prototype
};
@@ -1526,7 +1492,7 @@ WebInspector.RemoteFunction.prototype = {
function functionDetails(targetFunction)
{
var boundReleaseFunctionDetails = releaseTargetFunction.bind(null, this._object !== targetFunction ? targetFunction : null);
- return targetFunction.functionDetailsPromise().then(boundReleaseFunctionDetails);
+ return targetFunction.debuggerModel().functionDetailsPromise(targetFunction).then(boundReleaseFunctionDetails);
}
/**

Powered by Google App Engine
This is Rietveld 408576698