third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html - Issue 2122423002: [DevTools] Remove functionDetails from protocol.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html

Issue 2122423002: [DevTools] Remove functionDetails from protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html » ('j') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html b/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html

index 18168c826ecc405e0e861473484fbb2e640c1e88..dec791a62136110c302c61f43e09d3e07f013190 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html

@@ -23,13 +23,17 @@ function test()

function callbackEvalFunctionObject(response)

{

var functionObjectId = response.result.result.objectId;

- InspectorTest.sendCommand("Debugger.getFunctionDetails", { functionId: functionObjectId }, callbackFunctionDetails);

+ InspectorTest.sendCommand("Runtime.getProperties", { objectId: functionObjectId }, callbackFunctionDetails);

}

function callbackFunctionDetails(response)

{

var result = response.result;

- var scriptId = result.details.location.scriptId;

+ var scriptId;

+ for (var prop of result.internalProperties) {

+ if (prop.name === "[[FunctionLocation]]")

+ scriptId = prop.value.value.scriptId;

+ }

nextScenarioStep(0);